Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey AT Ibft2ProposeRpcAcceptanceTest.validatorsCanBeAddedAndThenRemoved #1023

Closed
RatanRSur opened this issue Jun 2, 2020 · 2 comments
Assignees
Labels
flake 60% of the time it works 100% of the time. TeamGroot GH issues worked on by Groot Team

Comments

@RatanRSur
Copy link
Contributor

RatanRSur commented Jun 2, 2020

Logs here:
6.txt

@RatanRSur RatanRSur added the flake 60% of the time it works 100% of the time. label Jun 2, 2020
@RatanRSur
Copy link
Contributor Author

@rain-on So once I got the out of memory issue fixed, it turns out that it's failing for real now. Because of the dreaded git blame, I assigned this to you but feel free to find whoever else you think is better suited to it.

@rain-on
Copy link
Contributor

rain-on commented Jun 7, 2020

From a review of the log file, it appears that Validator1 stops importing blocks after #37 - which I believe is the first block to contain a proposal for "non-validator" - #38 would contain the second proposal.

Because Validator-1 stopped importing blocks, its internal tracking of validators would have also stopped - thus the failure we see (which is that Validator1 does not see a change in the validator pool).

The log file does not give any hints as to why Validator1 stopped importing blocks - but the node must still be running otherwise the JSON RPC requests to validator1 would fail with a socket error.

Final intersting point (red-herring) - at the end of the test, it can be seen that the validator1 process has already terminated.

@vmichalik vmichalik added the TeamGroot GH issues worked on by Groot Team label Aug 15, 2021
@jframe jframe closed this as completed Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flake 60% of the time it works 100% of the time. TeamGroot GH issues worked on by Groot Team
Projects
None yet
Development

No branches or pull requests

4 participants