Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pki - migrate tests from Junit4 to Junit5 #5560

Closed
macfarla opened this issue Jun 9, 2023 · 2 comments · Fixed by #6235
Closed

pki - migrate tests from Junit4 to Junit5 #5560

macfarla opened this issue Jun 9, 2023 · 2 comments · Fixed by #6235
Assignees
Labels
good first issue Good for newcomers TeamRevenant GH issues worked on by Revenant Team testing

Comments

@macfarla
Copy link
Contributor

macfarla commented Jun 9, 2023

Module pki
eg
public abstract class BaseKeyStoreFileWrapperTest

Here's an example that migrates parameterized tests https://github.com/hyperledger/besu/pull/4975/files

@macfarla macfarla added good first issue Good for newcomers TeamRevenant GH issues worked on by Revenant Team testing labels Jun 9, 2023
@fspirola
Copy link
Contributor

fspirola commented Nov 5, 2023

I want to work on this issue can you assign to me.

@macfarla
Copy link
Contributor Author

macfarla commented Dec 1, 2023

@fspirola are you still working on this? shout out if you need any pointers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers TeamRevenant GH issues worked on by Revenant Team testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants