Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove backward sync functionality from engine_newPayload. #5687

Open
siladu opened this issue Jul 10, 2023 · 2 comments
Open

Remove backward sync functionality from engine_newPayload. #5687

siladu opened this issue Jul 10, 2023 · 2 comments

Comments

@siladu
Copy link
Contributor

siladu commented Jul 10, 2023

Only trigger backward sync on engine_forkchoiceUpdated.

Fixes #5411

This is a significant improvement for at least besu-nimbus pairs, off the back off #5411 (comment)
and has been tested successfully with Teku and Nimbus, see POC #5666

Main thing to work out is if we should return SYNCING, ACCEPTED or something else in this case.


Spec allows it:

https://github.com/ethereum/execution-apis/blob/main/src/engine/paris.md#specification
(newPayload)

Client software MAY initiate a sync process if requisite data for payload validation is missing. Sync process is specified in the Sync section.


Geth impl: https://github.com/ethereum/go-ethereum/blob/59f7b289c329b5a56fa6f4e9acee64e504c4cc0d/eth/catalyst/api.go#L476-L485

Note, geth also stash away these newPayloads for later use. That would be a further optimism but is not critical for this issue.

@siladu siladu changed the title Only Trigger Backward Sync on engine_forkchoiceUpdated Remove backward sync functionality from engine_newPayload. Jul 10, 2023
@siladu siladu added TeamGroot GH issues worked on by Groot Team TeamChupa GH issues worked on by Chupacabara Team labels Aug 4, 2023
@non-fungible-nelson
Copy link
Contributor

@siladu - can we status this, #5622, and #5411?

Do we think #5699 solves these?

@non-fungible-nelson
Copy link
Contributor

bump for status

@jflo jflo removed TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants