Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devnet9 Hive Fail - peering fail on ForkID tests #5924

Closed
jflo opened this issue Sep 21, 2023 · 5 comments
Closed

Devnet9 Hive Fail - peering fail on ForkID tests #5924

jflo opened this issue Sep 21, 2023 · 5 comments
Assignees
Labels
TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team

Comments

@jflo
Copy link
Contributor

jflo commented Sep 21, 2023

To reproduce, i use the following setup to debug hive tests:

i hacked a thing: ethereum/hive@master...jflo:hive:local_debug_hacks

which uses this snooper as a fake client

ethpandaops/json_rpc_snoop@master...jflo:json_rpc_snoop:dualSnoopers

which you'll have to build and tag, so the hive test will use it.

then ran hive like:

./hive -sim ethereum/engine -client-file ./configs/local-client.yaml --sim.limit "engine-cancun/ForkID: Genesis at " --docker.output to isolate a single test, and step through in my debugger.

ForkID: Genesis at * are the tests failing. Suspect peers may be disagreeing over forkId.

@jflo jflo added TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team TeamChupa GH issues worked on by Chupacabara Team labels Sep 21, 2023
@Gabriel-Trintinalia
Copy link
Contributor

This seems to work in their environment. Need to understand what is different

@non-fungible-nelson
Copy link
Contributor

Need to confirm this is still passing in the hive environment.

@macfarla
Copy link
Contributor

It is failing in the hive environment. error indicates unable to connect to mock client

FAIL: Error waiting for response: could not rlp decode message: EOF

@Gabriel-Trintinalia
Copy link
Contributor

Gabriel-Trintinalia commented Sep 27, 2023

Removing the code below from the fork_id.go in the engine simulator makes the tests pass. It looks like an issue when waiting for the pong response

```

// Finally wait for the pong response
/* msg, err := conn.WaitForResponse(timeout, 0)
if err != nil {
t.Fatalf("FAIL: Error waiting for response: %v", err)
}
switch msg := msg.(type) {
case devp2p.Pong:
t.Logf("INFO: Received pong response: %v", msg)
default:
t.Fatalf("FAIL: Unexpected message type: %v", err)
}
/

@Gabriel-Trintinalia
Copy link
Contributor

Fixed by #5955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TeamChupa GH issues worked on by Chupacabara Team TeamGroot GH issues worked on by Groot Team TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

No branches or pull requests

4 participants