Refactor eth_getBlockReceipts to use getTxReceipts(blockHash)

[macfarla]

Refactor eth_getBlockReceipts to use BlockChainQueries.getTxReceipts which already gets all the receipts by block hash.

Current impl loops through receipts in each tx for a block. Would be more efficient to use this method directly.

See #5771

[Shritesh99]

Hi, can I work on the issue?

[hellojaliyah]

Hi, I'd like to take a look.

[Sah314]

@macfarla i have almost understood the issue, can you assign it to me.

[non-fungible-nelson]

Hi folks - no assignee needed to work on this. Please open any PRs to complete this issue and tag us! In the spirit of open-source, we encourage all contributions. there are also plenty of other issues with the good first issues tag if you are eager. Reach out on discord.gg/hyperledger in the #besu-contributors channel if you have questions or want to submit a PR for review or feedback.

[siladu]

Other good first issues: https://github.com/hyperledger/besu/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[Shritesh99]

Hi @macfarla, I have analyzed the issue. BlockChainQueries.getTxReceipts(blockHash) returns List of TransactionReceipt however, getBlockReceiptsResult expects to return List of TransactionReceiptWithMetadata. No wrapper can convert TransactionReceipt to TransactionReceiptWithMetadata without looping through each tx for a block.