Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated --host-whitelist option #7761

Closed
jflo opened this issue Oct 11, 2024 · 5 comments · Fixed by #8012
Closed

Remove deprecated --host-whitelist option #7761

jflo opened this issue Oct 11, 2024 · 5 comments · Fixed by #8012
Assignees
@macfarla @pr9t
Labels
good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev

Comments

@jflo
Copy link
Contributor

jflo commented Oct 11, 2024 •
edited by macfarla
Loading

The option --host-whitelist has been deprecated since 2020, and can be removed now.

-- host-allowlist already exists as an alias for this option, so it's only removing the name, not the functionality

Add to the upcoming changelog to indicate it will be removed soon.
@jflo jflo added good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev labels Oct 11, 2024
@jflo jflo mentioned this issue Oct 11, 2024
Merged
@TC1211
Copy link

TC1211 commented Oct 13, 2024

Could me and @JanetMo take this issue?

@macfarla
Copy link
Contributor

@JanetMo you need to comment on here and then can assign you

@JanetMo
Copy link

JanetMo commented Oct 16, 2024

Yes I would work with @TC1211 on the issue, thanks!

@jflo
Copy link
Contributor Author

jflo commented Oct 17, 2024

assigned to you two, enjoy.

@JanetMo JanetMo mentioned this issue Nov 2, 2024
Closed
@JanetMo JanetMo mentioned this issue Nov 17, 2024
Closed
This was referenced Dec 3, 2024
Closed
Open
@macfarla macfarla assigned macfarla and unassigned TC1211 and JanetMo Dec 9, 2024
@pr9t
Copy link
Contributor

pr9t commented Dec 9, 2024

Hi @macfarla please assign this issue to me.

@pr9t pr9t mentioned this issue Dec 10, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macfarla macfarla

@pr9t pr9t

Labels
good first issue Good for newcomers snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore!: Removed Deprecated --host-whitelist option pr9t/besu
6 participants
@jflo @macfarla @TC1211 @pr9t @JanetMo and others