Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cactus-core-api): interface i-cactus-plugin in the function isICactusPlugin is not checking for required onPluginInit #1277

Closed
m-courtin opened this issue Aug 30, 2021 · 0 comments · Fixed by #1278
Closed

fix(cactus-core-api): interface i-cactus-plugin in the function isICactusPlugin is not checking for required onPluginInit #1277

m-courtin opened this issue Aug 30, 2021 · 0 comments · Fixed by #1278
Labels
bug Something isn't working

Comments

@m-courtin
Copy link
Contributor

Describe the bug

The newest version of Cactus is missing a check on the required 'onPluginInit' function in the 'isICactusPlugin' function defined in the interface i-cactus-plugin.
@m-courtin m-courtin added the bug Something isn't working label Aug 30, 2021
@m-courtin m-courtin changed the title fix(cactus-core-api): interface i-cactus-plugin fix function isICactusPlugin fix(cactus-core-api): interface i-cactus-plugin in the function isICactusPlugin is not checking for required onPluginInit Aug 30, 2021
m-courtin added a commit to m-courtin/cactus that referenced this issue Aug 30, 2021
@m-courtin
fix: check for req function onPluginInit in isCactusPlugin
d5be337 
interface i-cactus-plugin in the function isICactusPlugin is not
checking for required onPluginInit

Closes: hyperledger-cacti#1277
Signed-off-by: Michael Courtin <[email protected]>
@m-courtin m-courtin mentioned this issue Aug 30, 2021
Merged
petermetz pushed a commit that referenced this issue Aug 31, 2021
@m-courtin @petermetz
fix: check for req function onPluginInit in isCactusPlugin
f5ffb92 
interface i-cactus-plugin in the function isICactusPlugin is not
checking for required onPluginInit

Closes: #1277
Signed-off-by: Michael Courtin <[email protected]>
RafaelAPB pushed a commit to RafaelAPB/blockchain-integration-framework that referenced this issue Mar 9, 2022
@m-courtin @RafaelAPB
fix: check for req function onPluginInit in isCactusPlugin
ce45609 
interface i-cactus-plugin in the function isICactusPlugin is not
checking for required onPluginInit

Closes: hyperledger-cacti#1277
Signed-off-by: Michael Courtin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@m-courtin