Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): force minimist >=1.2.6 for CVE-2021-44906 #1943

Closed
petermetz opened this issue Mar 23, 2022 · 0 comments · Fixed by #1944
Closed

fix(deps): force minimist >=1.2.6 for CVE-2021-44906 #1943

petermetz opened this issue Mar 23, 2022 · 0 comments · Fixed by #1944
Assignees
@petermetz
Labels
dependencies Pull requests that update a dependency file P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities

Comments

@petermetz
Copy link
Contributor

https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-44906

https://github.com/substack/minimist/commit/ef88b9325f77b5ee643ccfc97e2ebda577e4c4e2

Please use version 1.2.6 or later:
@petermetz petermetz added dependencies Pull requests that update a dependency file P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities labels Mar 23, 2022
@petermetz petermetz self-assigned this Mar 23, 2022
petermetz added a commit to petermetz/cacti that referenced this issue Mar 23, 2022
@petermetz
fix(deps): force minimist >=1.2.6 for CVE-2021-44906
526839b 
Ensures that yarn will only install 1.2.6 or newer versions for
minimist.

The proper fix would be to have the dependencies issue releases
which upgrade their own (transitive) dependencies of minimist
so that we don't have to explicitly force it here, but at the time
of this writing these upgrades in our direct dependencies are just
not available yet.

Fixes hyperledger-cacti#1943

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz mentioned this issue Mar 23, 2022
Merged
takeutak pushed a commit that referenced this issue Mar 23, 2022
@petermetz @takeutak
fix(deps): force minimist >=1.2.6 for CVE-2021-44906
b96806a 
Ensures that yarn will only install 1.2.6 or newer versions for
minimist.

The proper fix would be to have the dependencies issue releases
which upgrade their own (transitive) dependencies of minimist
so that we don't have to explicitly force it here, but at the time
of this writing these upgrades in our direct dependencies are just
not available yet.

Fixes #1943

Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petermetz petermetz

Labels
dependencies Pull requests that update a dependency file P1 Priority 1: Highest Security Related to existing or potential security vulnerabilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): force minimist >=1.2.6 for CVE-2021-44906 petermetz/cacti
1 participant
@petermetz