From 867baf6880db7fc0b3d08a48cf4e6e5fb1abb868 Mon Sep 17 00:00:00 2001 From: Joshua Goldstein Date: Tue, 11 Apr 2023 23:52:31 -0500 Subject: [PATCH 1/3] increase wait for compaction to finish and add explicit unlock --- value_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/value_test.go b/value_test.go index d4e05fe1f..f76b70fb4 100644 --- a/value_test.go +++ b/value_test.go @@ -522,7 +522,7 @@ func TestPersistLFDiscardStats(t *testing.T) { require.NoError(t, err) } - time.Sleep(2 * time.Second) // wait for compaction to complete + time.Sleep(4 * time.Second) // wait for compaction to complete persistedMap := make(map[uint64]uint64) db.vlog.discardStats.Lock() @@ -530,7 +530,7 @@ func TestPersistLFDiscardStats(t *testing.T) { db.vlog.discardStats.Iterate(func(fid, val uint64) { persistedMap[fid] = val }) - + db.vlog.discardStats.Unlock() require.NoError(t, db.Close()) // Avoid running compactors on reopening badger. From 33e98da5650a8d4f0faa2c6fb2d4241228ee4341 Mon Sep 17 00:00:00 2001 From: Joshua Goldstein Date: Wed, 12 Apr 2023 00:37:16 -0500 Subject: [PATCH 2/3] increase sleep --- value_test.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/value_test.go b/value_test.go index f76b70fb4..8c667f916 100644 --- a/value_test.go +++ b/value_test.go @@ -530,6 +530,7 @@ func TestPersistLFDiscardStats(t *testing.T) { db.vlog.discardStats.Iterate(func(fid, val uint64) { persistedMap[fid] = val }) + db.vlog.discardStats.Unlock() require.NoError(t, db.Close()) @@ -538,7 +539,7 @@ func TestPersistLFDiscardStats(t *testing.T) { db, err = Open(opt) require.NoError(t, err) defer db.Close() - time.Sleep(1 * time.Second) // Wait for discardStats to be populated by populateDiscardStats(). + time.Sleep(4 * time.Second) // Wait for discardStats to be populated by populateDiscardStats(). db.vlog.discardStats.Lock() statsMap := make(map[uint64]uint64) db.vlog.discardStats.Iterate(func(fid, val uint64) { From 8e8b25f795fe5111881dc8135f96b06f37d3b948 Mon Sep 17 00:00:00 2001 From: Joshua Goldstein <92491720+joshua-goldstein@users.noreply.github.com> Date: Thu, 4 May 2023 12:08:58 -0500 Subject: [PATCH 3/3] Remove extra sleeps --- value_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/value_test.go b/value_test.go index 8c667f916..138ae74c8 100644 --- a/value_test.go +++ b/value_test.go @@ -522,7 +522,7 @@ func TestPersistLFDiscardStats(t *testing.T) { require.NoError(t, err) } - time.Sleep(4 * time.Second) // wait for compaction to complete + time.Sleep(2 * time.Second) // wait for compaction to complete persistedMap := make(map[uint64]uint64) db.vlog.discardStats.Lock() @@ -539,7 +539,7 @@ func TestPersistLFDiscardStats(t *testing.T) { db, err = Open(opt) require.NoError(t, err) defer db.Close() - time.Sleep(4 * time.Second) // Wait for discardStats to be populated by populateDiscardStats(). + time.Sleep(1 * time.Second) // Wait for discardStats to be populated by populateDiscardStats(). db.vlog.discardStats.Lock() statsMap := make(map[uint64]uint64) db.vlog.discardStats.Iterate(func(fid, val uint64) {