Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adder occluded for certain gh views - z-index issue? #5622

Open
dwhly opened this issue Jul 11, 2023 · 4 comments
Open

Adder occluded for certain gh views - z-index issue? #5622

dwhly opened this issue Jul 11, 2023 · 4 comments
Labels

Comments

@dwhly
Copy link
Member

dwhly commented Jul 11, 2023

When trying to annotate a gh draft the modal is over top of the adder.

Image

@dwhly dwhly added the bug label Jul 11, 2023
@robertknight
Copy link
Member

Does using the "a" / "h" keys to annotate still work?

@dwhly
Copy link
Member Author

dwhly commented Jul 11, 2023

Yes.

@mkdir-washington-edu
Copy link
Contributor

I can reproduce:

  1. Go to https://github.com/orgs/hypothesis/projects/120/views/1
  2. Click on a single issue so it opens
  3. Activate Hypothesis
  4. Highlight the repo name and issue number at the top of the issue
  5. The Adder is hidden behind the issue:
Screen Shot 2023-08-03 at 4 37 26 PM

There are some strange z-indices on this page, but I can't tell if they apply to the popped out issue or not.

@acelaya
Copy link
Contributor

acelaya commented Aug 4, 2023

I can confirm this is a z-index issue. The element rendered over the adder has z-index: 10 (one of its parents, actually), while the adder has z-index: 3. Increasing it to something >10 fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants