-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
development mode and build mode instrument result is different in SSR project #67
Comments
Hi @sunnywanggit, I'll look at this and see if i can find a cause. Might be an error when the instrumenter gets the ID for the file as the filenames are different in build and in serve mode. |
@iFaxity Thanks a lot |
After looking into this there could be a fix to manipulate the module ID to remove the query parameters after the file path. However not sure what consequence this can have on other setups. I will try this approach as there seem to not be a fix using Vite/Rollups own API. as getFileName is not valid for the modules and getModuleInfo does not yield anything interesting. The query parameters is only there for the Vue plugin to know how to parse the file, nothing else it seems. |
@sunnywanggit Please try the solution release in the version v4.0.0-rc.2. If it is ok i will publish it along a release in the future, but for now it is in a release candidate to try out the feature |
I tested it on version v4.0.0-rc.2 and it's working fine, I was scared because in the beginning it was the cache hahaha, thanks a lot for the project it helped a lot! I felt some difficulties because it doesn't have much content, but I want to see if I contribute to the community. PS: I'm Brazilian and I'm using google translator, sorry if the translation is bad |
@vduggen No worries I understand you just fine 😊. Great that the solution worked, I will publish it in a stable release very soon. Thanks for contributing 👍. |
🎉 This issue has been resolved in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the bug
development mode and build mode instrument result is different in SSR project
development mode:
![image](https://user-images.githubusercontent.com/53786183/211206486-4d6ee406-1424-4b26-b80e-e98d41c194be.png)
build mode:
![image](https://user-images.githubusercontent.com/53786183/211206439-8958ff69-ffd9-4c90-9ab2-c3cfd0b7870a.png)
Reproduction
https://github.com/sunnywanggit/coverage
Steps to reproduce
No response
System Info
Used Package Manager
yarn
Logs
No response
Validations
The text was updated successfully, but these errors were encountered: