Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format 格式化字符串错误，理解的不对吗？ #1334

Closed
steady-join opened this issue Jan 14, 2021 · 5 comments
Closed

format 格式化字符串错误，理解的不对吗？ #1334

steady-join opened this issue Jan 14, 2021 · 5 comments

Comments

@steady-join
Copy link

Describe the bug
A clear and concise description of what the bug is.
image

Expected behavior
A clear and concise description of what you expected to happen.
image

Information

  • Day.js Version [e.g. v1.0.0]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome 62]
  • Time zone: [e.g. GMT-07:00 DST (Pacific Daylight Time)]
    v1.10.3
@iamkun
Copy link
Owner

iamkun commented Jan 14, 2021

what's the bug is then?

@steady-join
Copy link
Author

what's the bug is then?

Will the string type here be implicitly converted to a number type?

@iamkun
Copy link
Owner

iamkun commented Jan 14, 2021

No, check here, https://day.js.org/docs/en/parse/unix-timestamp-milliseconds

The passing argument must be a number

@lqzhgood
Copy link

#1150

image

in development has warn tips. is not bug.

@iamkun
Copy link
Owner

iamkun commented Jul 6, 2021

I'll close this issue since it's been a while since it's been opened. Feel free to reopen if you have updates on this

@iamkun iamkun closed this as completed Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lqzhgood @iamkun @steady-join