this.document.getPreviousInline is not a function

[kalley]

Do you want to request a feature or report a bug?

bug

What's the current behavior?

When calling value.previousInline, and error gets thrown because this.document.getPreviousInline is not a function

fiddle: https://jsfiddle.net/qmxu8ocy/ (type anything)

OS: mac
browser: Chrome
slate version: 0.33.4

What's the expected behavior?

It would return the previous inline if it existed.

I'm getting around it right now by using value.document.getPreviousSibling and checking if it's inline or not. I looked through history and I'm not sure that getPreviousInline ever existed 🤷‍♂️

[davidchang]

seems like

slate/packages/slate/src/models/value.js

Lines 472 to 490 in 9e50bc6

	/**
	* Get the next inline node.
	*
	* @return {Inline}
	*/
	get nextInline() {
	return this.endKey && this.document.getNextInline(this.endKey)
	}
	/**
	* Get the previous inline node.
	*
	* @return {Inline}
	*/
	get previousInline() {
	return this.startKey && this.document.getPreviousInline(this.startKey)
	}

should be removed from the value API, though that might warrant a minor version bump? looks like neither previousInline nor nextInline in the Slate codebase itself. unless we want to implement getPreviousInline and getNextInline on document

[ianstormtaylor]

Open to a PR that adds those two.

[ianstormtaylor]

As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.