don't re-render editor during compositions

[ianstormtaylor]

Do you want to request a feature or report a bug?

Bug,

What's the current behavior?

Right now we re-render the editor to show/hide the placeholder during compositionstart and compositionend events. But this results in the composition being aborted/broken in some IMEs.

What's the expected behavior?

We need to change this logic to no re-render the editor, but just re-render the placeholder itself I think. This could be accomplished with some sort of "connected" <Placeholder> component I believe, which can be toggled from the plugin code.

This is related to #2062.

[zhujinxuan]

Hi, I am not sure why we put isComposing in state. this.setState is not immediate, and can cause re-render.

Is there a special reason of putting isComposing in state?

[ianstormtaylor]

@zhujinxuan check out the comments in the source linked above.