You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the current way next() is written, it results in longer callstacks that go something like:
onCommand
next
onCommand
next
onCommand
next
onCommand
next
But I don't think this is strictly necessary...
What's the expected behavior?
If we changed the implementation to use a loop instead, and make next just toggle a "continuation" boolean instead, I think we could achieve the same behavior with a flat call stack?
I'm not super familiar with the pros/cons of this. But it would make debugging nicer I'd think. Also it might avoid stack overflows in some cases since plugin count is no longer a factor.
The text was updated successfully, but these errors were encountered:
Do you want to request a feature or report a bug?
Improvement?
What's the current behavior?
With the current way
next()
is written, it results in longer callstacks that go something like:But I don't think this is strictly necessary...
What's the expected behavior?
If we changed the implementation to use a loop instead, and make
next
just toggle a "continuation" boolean instead, I think we could achieve the same behavior with a flat call stack?I'm not super familiar with the pros/cons of this. But it would make debugging nicer I'd think. Also it might avoid stack overflows in some cases since plugin count is no longer a factor.
The text was updated successfully, but these errors were encountered: