Operation.toJSON does not save selection's value - Saving history

[callingmybluff]

Do you want to request a feature or report a bug?

A bug

What's the current behavior?

https://jsfiddle.net/Ismaeel/xvgoqLn2/

1. Place the cursor anywhere inside the text
2. Click on Click To Do Nothing (it will reset the history by using the history itself, but each operations is re sat to its value after to/from JSON: op = Operation.fromJSON(op.toJSON())
3. Click on the redo button, which calls the native this.editor.undo.
4. An error appears in the console: Uncaught TypeError: Cannot read property 'merge' of undefined

Slate 0.44.12, Chrome latest (73.0.3683.86 64bit), and Windows7

What's the expected behavior?

I would like to save the history in a JSON and load from a JSON too (replay what the user did step per step). I can use something like deep-diff, but using them would be much faster (although maybe not memory-friendly).

If you think this is a valid bug and you would accept a pull request for it, I will happily do that. Please let me know if you want me to create an example for it, too (or extend the versioning example as it only saves in memory for now).

[isubasti]

@callingmybluff there's an option to preserveSelectionon toJSON

[callingmybluff]

@callingmybluff there's an option to preserveSelectionon toJSON

Did you try the example? It does nothing, or I am using it wrong? According to the documentation, it reserves JSON for the data as a whole, not to Operation.

https://jsfiddle.net/Ismaeel/xvgoqLn2/35/

[callingmybluff]

Possible solution would probably be by adding (as in: https://jsfiddle.net/Ismaeel/xvgoqLn2/40/) :

if (options.preseveSelection && op.selection)
    json.selection = op.selection.toJSON();

I will create a pull request for it

[ianstormtaylor]

As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.