You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's a chance that these are expensive from a performance stand point if we're doing tons of validations. I'm not sure... I guess the normal case involves most things being valid and not invalid.
But it could be something to check out, since there's no real exception being raised, we don't need a full blown error object. And if it improves performance of normalization that could be big.
The text was updated successfully, but these errors were encountered:
Do you want to request a feature or report a bug?
Idea.
What's the current behavior?
Right now when doing normalization we create
SlateError
objects:slate/packages/slate/src/plugins/schema.js
Line 130 in 62ca870
Creating errors objects is a lot more expensive than creating objects: https://jsperf.com/error-vs-object-instantiation
There's a chance that these are expensive from a performance stand point if we're doing tons of validations. I'm not sure... I guess the normal case involves most things being valid and not invalid.
But it could be something to check out, since there's no real exception being raised, we don't need a full blown error object. And if it improves performance of normalization that could be big.
The text was updated successfully, but these errors were encountered: