setValue in controllers/editor.js causes race conditions

[bryanph]

Do you want to request a feature or report a bug?

Bug

What's the current behavior?

setValue is called in two places in the controller:

1. Reacting to a prop change (

   slate/packages/slate/src/controllers/editor.js

   Line 378 in 5b8a6bb

   this.value = value

   )
2. Reacting to an internal state change (

   slate/packages/slate/src/controllers/editor.js

   Line 98 in 5b8a6bb

   this.value = operation.apply(value)

   )

Because of the asynchronous nature of the two, it is possible that a rerender occurs whilst slate is applying operations locally. This has as a result that onChange wll be called with an inconsistent value.

What's the expected behavior?

value should be set either internally or through props only so that updates can correctly be queued in some way and race conditions do not occur.

[ianstormtaylor]

As of #3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I'm going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.