Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all key usage from Slate's core #2864

Closed
ianstormtaylor opened this issue Jun 7, 2019 · 1 comment
Closed

remove all key usage from Slate's core #2864

ianstormtaylor opened this issue Jun 7, 2019 · 1 comment

Comments

@ianstormtaylor
Copy link
Owner

ianstormtaylor commented Jun 7, 2019

Do you want to request a feature or report a bug?

Debt.

What's the current behavior?

Right now we use keys all over the place, because we didn't use to have "paths" as a concept. Often the key usage is a crutch for logic that can be made even simpler and more performant by using paths—although this isn't always true. Either way we need to eliminate keys to for #2495 to be able to remove the instantiation step.

What's the expected behavior?

Remove all of the logic in the core slate package that depends on keys. Everything should use paths instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant