Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup delete tests #2867

Closed
ianstormtaylor opened this issue Jun 9, 2019 · 1 comment
Closed

cleanup delete tests #2867

ianstormtaylor opened this issue Jun 9, 2019 · 1 comment
Labels

Comments

@ianstormtaylor
Copy link
Owner

Do you want to request a feature or report a bug?

Debt.

What's the current behavior?

There are lots of tests for editor.delete() right now that are poorly named, or that contain too much extraneous stuff in the test cases's document that isn't directly related to the specific behavior being tested.

image

It makes it hard to reason about what exactly is failing when a test fails. They should be cleaned up to have a consistent naming scheme. And remove any extra nodes/text that isn't necessary for each test's behavior.

@ianstormtaylor
Copy link
Owner Author

I believe that this may be fixed by #3093, which has changed a lot of the logic in Slate and slate-react especially. I'm going to close this out, but as always, feel free to open a new issue if it persists for you. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant