Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade memoize-one dependency #2968

Closed
feimosi opened this issue Aug 13, 2019 · 1 comment
Closed

Upgrade memoize-one dependency #2968

feimosi opened this issue Aug 13, 2019 · 1 comment

Comments

@feimosi
Copy link

feimosi commented Aug 13, 2019

Do you want to request a feature or report a bug?

Potential bug

What's the current behavior?

Installing / Upgrading slate-react prints the following warning:

warning slate-react > [email protected]: New custom equality api does not play well with all equality helpers. Please use v5.x

What's the expected behavior?

Upgrading to memoize-one@5
@ianstormtaylor ianstormtaylor mentioned this issue Nov 6, 2019
Closed
@ianstormtaylor
Copy link
Owner

I believe that this may be fixed by #3093, which has changed a lot of the logic in Slate and slate-react especially. I'm going to close this out, but as always, feel free to open a new issue if it persists for you. Thanks for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Next ianstormtaylor/slate
2 participants
@ianstormtaylor @feimosi