Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection via mouse across void nodes not worked #3648

Closed
jerkly opened this issue May 4, 2020 · 6 comments
Closed

Selection via mouse across void nodes not worked #3648

jerkly opened this issue May 4, 2020 · 6 comments

Comments

@jerkly
Copy link
Contributor

jerkly commented May 4, 2020

Do you want to request a feature or report a bug?

bug

What's the current behavior?

Selection with mouse are collapsed, when hitting void node's edge.

Mention example:
https://www.slatejs.org/examples/mentions
screencast-www slatejs org-2020 05 04-05_35_00

Image example:
https://www.slatejs.org/examples/images
screencast-www slatejs org-2020 05 04-05_43_31

Slate: 0.XX.X
Browser: Chrome / Safari / Firefox / Edge
OS: Mac / Windows / Linux / iOS / Android

What's the expected behavior?

Selection is not collapsed, when selecting via mouse across void nodes

@jerkly
Copy link
Contributor Author

jerkly commented May 4, 2020

Selection with keyboard arrows works as expected.

@knubie
Copy link
Contributor

knubie commented May 4, 2020

Was this fixed in #3594? (Potential duplicate of #1969)

@jerkly
Copy link
Contributor Author

jerkly commented May 4, 2020

@knubie, #3594 is not fixed selection in all cases (only selection via keyboard). Bug are still present in Slate 0.57.2.
Look at the mention and image example https://www.slatejs.org/examples/mentions and try to select across voids via mouse.

@knubie
Copy link
Contributor

knubie commented May 4, 2020

Bug are still present in Slate 0.57.2.

#3594 Is not included in 57.2. Could you try master?

@jerkly
Copy link
Contributor Author

jerkly commented May 4, 2020

Bug are still present in Slate 0.57.2.

#3594 Is not included in 57.2. Could you try master?

Master checked again. Voids with extra content (i.e mention or embed) selectable only via keyboard.
With mouse selection there are two cases:

  • selection via Shift + mouse_click working
  • selection via mouse_move not working

@jerkly
Copy link
Contributor Author

jerkly commented May 5, 2020

fixed in #3649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants