Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to set custom "boundary" to define scrolling container for the library scroll-into-view-if-needed #4590

Open
ugrinovsky opened this issue Oct 11, 2021 · 2 comments
Open

Unable to set custom "boundary" to define scrolling container for the library scroll-into-view-if-needed #4590

ugrinovsky opened this issue Oct 11, 2021 · 2 comments
Labels
feature

Comments

@ugrinovsky
Copy link

ugrinovsky commented Oct 11, 2021 •
edited
Loading

Problem
At the moment, the editor itself should be a scroll container. But if the scroll container needs to be above the editor, the scrolling logic will break.

Solution
I suggest adding an prop for the editor:

slate/packages/slate-react/src/components/android/android-editable.tsx

Line 170 in d06706c

scrollIntoView(leafEl, {

slate/packages/slate-react/src/components/editable.tsx

Line 1305 in 7ba486a

scrollIntoView(leafEl, {

slate-react:

scrollIntoView(leafEl, {
      scrollMode: 'if-needed',
      boundary: props.scrollBoundary || el
});

custom code:

const resolveScrollBoundary = (parent) => {
      return return !parent.classList.contains('.someClassName');
};

//...

<SlateEditable
      scrollBoundary={this.resolveScrollBoundary}
/>
@max-sym
Copy link

max-sym commented Oct 12, 2021

What do you mean exactly by "the scrolling logic will break" here?

For me, it scrolls the <html /> tag instead of my scrolling div.

@max-sym
Copy link

max-sym commented Oct 12, 2021

Similar thread in the scroll-into-view-if-needed repo: scroll-into-view/scroll-into-view-if-needed#635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ugrinovsky @max-sym