Throw window to any space across multiple screens. #1209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently throwing windows to spaces given the space number only works for a single screen. You cannot throw a window to a space belonging to a different screen. This is confusing when managing windows in a multi-screen setup as you need to think about screen numbers locally to the screen as well as globally across all screens. It creates more steps when issuing keyboard commands i.e. instead of throwing a window to space X on which exists on screen A directly, you must first throw the window to screen A and then throw it to space X' which is the index of screen X local to screen A. Finally the current behaviour deviates from the existing XMonad behaviour which allows throwing windows to arbitrary globally indexed workspaces.
|
I think adding this behaviour makes sense but I appreciate it would break the existing behaviour for folks as a result. I think the best thing is to hide the behaviour behind a flag in preferences but I haven't looked into how to do that. I'd appreciate if anyone with experience in modifying the preferences code could make that change. |
|
I also need to reflow the recipient space as it will not tile correctly if the space is already visible on a screen. Will drop an update shortly. |
|
I've sorted reflow when moving windows between spaces on different screens. |
|
Very cool. Much appreciated contribution. I'll think about how it fits into settings. |
ianyh
approved these changes
May 7, 2022
ianyh
added a commit
to reyk/Amethyst
that referenced
this pull request
May 7, 2022
* development: Throw window to any space across multiple screens. (ianyh#1209) Make TwoPane layout adaptive to screen orientation (ianyh#1182) Minor fix (line 69) (ianyh#1230) Bump cocoapods-downloader from 1.5.1 to 1.6.3 (ianyh#1226) Fix the layout HUD when multiple screen are arranged vertically (ianyh#1162) (ianyh#1163) Bump version to 0.15.6 (ianyh#1205) Remove errant link (ianyh#1207) Replace gitter with GitHub Discussions (ianyh#1206) Update Window.swift (ianyh#1203) Fix setup.sh so that it correctly checks for rbenv (ianyh#1198) add regex suuport to floating windows title matching (ianyh#1166) Get the build going (ianyh#1185) Fix for move to window to space - ianyh#1174 (ianyh#1184) Update cocoapods in Gemfile (ianyh#1159) Remove travis file (ianyh#1158) Create GitHub Action for running tests (ianyh#1157) Add some common macOS agents to ignored list (ianyh#1156) Bump addressable from 2.7.0 to 2.8.0 (ianyh#1136)
ianyh
added a commit
that referenced
this pull request
May 21, 2022
* development: Fix swapping with two windows visible for two-pane layout (#1241) Add 4Column layout for ultra-wide screens (#1154) Throw window to any space across multiple screens. (#1209) Make TwoPane layout adaptive to screen orientation (#1182) Minor fix (line 69) (#1230) Bump cocoapods-downloader from 1.5.1 to 1.6.3 (#1226) Fix the layout HUD when multiple screen are arranged vertically (#1162) (#1163)
|
this is neat, I just ran the development branch, it makes a world of difference for me |
|
Great! This also fixes issue #856 (closed it). |
This was referenced Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the behaviour of throwing windows between spaces such that:
Currently throwing windows between spaces only works between spaces on the same screen. You cannot throw a window to a space belonging to a different screen. This is confusing when managing windows in a multi-screen setup i.e. instead of throwing a window to space X (where X is the Mission Control space number) which exists on screen A directly, you must first throw the window to screen A and then throw it to space X' which is the index of space X local to screen A. It creates more steps when issuing keyboard commands as explained in the example. Its also confusing from the fact that the space numbers shown in Mission Control do not reflect the space numbers used when throwing windows in a multi-screen setup. Finally the current behaviour deviates from the existing XMonad behaviour which allows throwing windows to arbitrary workspaces, regardless of which screen it is currently visible on.