Issue 1306: Fix "Follow thrown windows between spaces" setting not working #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves Issue #1306 (Throw a window to other spaces will follow the window to that space even when the settings is unchecked.)
It looks to me like PR #1209 broke the "follow thrown windows between spaces" setting by adding a new call to
window.focusthat was not gated by a check forUserConfiguration.shared.followWindowsThrownBetweenSpaces().Adding this check restores the expected behavior. This code builds and runs locally.
Pinging @dozzman as the author of PR #1209, just want to make sure adding this check doesn't break anything (I can't imagine it would, though).
Also thanks @ianyh for making contributing easy – I was able to get the project up and running in no time.