Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Dynamic Route Removal and Update Support in Matchit #44

Closed
bruno-ortiz opened this issue Nov 1, 2023 · 2 comments · Fixed by #49
Closed

Enhancement Request: Dynamic Route Removal and Update Support in Matchit #44

bruno-ortiz opened this issue Nov 1, 2023 · 2 comments · Fixed by #49
Labels
feature New feature or request

Comments

@bruno-ortiz
Copy link

I am in the process of developing a system that enables the dynamic registration and removal of HTTP routes while the service is in operation.

While Matchit offers impressive functionality, it currently lacks the capability to remove and update routes. Is there a possibility of incorporating these features into the framework?

I understand that there are existing workarounds for this limitation, but having built-in support for these actions in the future would be greatly appreciated.

Thank you for your dedication and hard work!

@ibraheemdev
Copy link
Owner

ibraheemdev commented Nov 2, 2023

I've heard of services that require this before, I'd happily accept a pull request implementing remove. Also something to consider - removing a route could allow affected static nodes to be merged with their parent, though this could be implemented later.

Updating a route's value is already supported via at_mut, unless you were referring to a different type of update?

@ibraheemdev ibraheemdev added the feature New feature or request label Nov 2, 2023
@ibraheemdev
Copy link
Owner

Released in 0.8.2. Thanks to @Totodore for their work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants