Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From dosbox-x : use overlay file when its newer than zips #18

Closed
thesnable opened this issue Mar 28, 2022 · 5 comments
Closed

From dosbox-x : use overlay file when its newer than zips #18

thesnable opened this issue Mar 28, 2022 · 5 comments

Comments

@thesnable
Copy link

Hi!

A very discrete problem:
i have a zip of an dos game. This is mounted via dosboxx via physfs overlay.
In this archive there is an file "sndcfg.ini". I need to replace this file while using the overlay. This is not possible. This the old file from the archive is used, although there is the new sndcfg.ini in the overlay part.

wish: in doubt use the overlays file (when its newer etc)

marco

@NebularNerd
Copy link

Seconding this request, the ability for the overlay to see newer versions of the file would be a great helps.

@icculus
Copy link
Owner

icculus commented Sep 8, 2022

If the overlay is mounted earlier in the search path, it should override the .zip file's version (and function as an "overlay" would be expected to). Is this not the case?

@NebularNerd
Copy link

With dosbox-x you have to mount the .zip then the overlay otherwise it throws up an error. Any totally new files are ok with changes being reflected as things should. However files that exist inside the zip then subsequently modified are not picked up. Not sure if this is due to a specific implementation of how DosBox-x uses PhyFS or an issue with the library. It's briefly discussed in joncampbell123/dosbox-x#3355

command_001

@icculus
Copy link
Owner

icculus commented Sep 8, 2022

https://github.com/joncampbell123/dosbox-x/blob/3b002fa724a67b3cf26d5030391cbf3d5dea90a0/src/dos/drive_physfs.cpp#L371

Make that 1 a 0 so the overlay gets checked for files before the thing it overlays.

@icculus
Copy link
Owner

icculus commented Sep 8, 2022

(Closing this under the assumption this isn't a PhysicsFS bug, but if there's more information later, please don't hesitate to mention it and we can reopen the bug.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants