Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Coverage tracking report implementation for test coverage #145

Closed
dwdraju opened this issue Aug 1, 2022 · 4 comments · Fixed by #364
Closed

Github Coverage tracking report implementation for test coverage #145

dwdraju opened this issue Aug 1, 2022 · 4 comments · Fixed by #364
Assignees
Labels
team: ibriz Relevant to iBriz type: build and ci Related to internal build or continuous integration processes

Comments

@dwdraju
Copy link
Contributor

dwdraju commented Aug 1, 2022

Overview

coveralls.io implementation and integration with Github Actions for tracking test coverage of icon-bridge repo.

Coveralls links

Language integration and libraries to use for submitting coverage report(docs.coveralls.io:

  1. Java: https://github.com/trautonen/coveralls-maven-plugin
  2. Solidity smart contracts: https://medium.com/edgefund/testing-and-code-coverage-of-solidity-smart-contracts-660cb6291701
  3. Javascript: https://docs.coveralls.io/javascript

Acceptance Criteria

  1. Github actions to trigger coverage tracking and send report to coveralls
  2. Github repo integration so that report(percentage coverage) is seen from github repo without landing on coveralls dashboard
@andrii-kl
Copy link
Collaborator

Looks good, just keep in mind that in java case we are using gradle. So the maven plugin can not working.

@dwdraju dwdraju self-assigned this Aug 1, 2022
@pragyanshrestha-ibriz pragyanshrestha-ibriz added the type: build and ci Related to internal build or continuous integration processes label Aug 4, 2022
@dwdraju
Copy link
Contributor Author

dwdraju commented Aug 8, 2022

We decided to go codecov because of it's support for monorepo like, test coverage show inside executed folder.

@dwdraju
Copy link
Contributor Author

dwdraju commented Aug 8, 2022

Example coverage reports on github side after implementation(integrated on private repo - will go to icon-bridge after repo gets public)
Screen Shot 2022-08-08 at 15.30.02.pngScreen Shot 2022-08-08 at 15.56.27.png
Screen Shot 2022-08-08 at 17.31.10.png

@pragyanshrestha-ibriz pragyanshrestha-ibriz changed the title Coveralls implementation for test coverage Github Coverage tracking report implementation for test coverage Aug 10, 2022
@dwdraju dwdraju added the status: in progress Contributor working on issue label Aug 28, 2022
@pragyanshrestha-ibriz pragyanshrestha-ibriz linked a pull request Aug 29, 2022 that will close this issue
@dwdraju
Copy link
Contributor Author

dwdraju commented Aug 31, 2022

The coverage report of solidity is not actual on the codecov dashboard. Probable reason is like this issue sc-forks/solidity-coverage#715
@sdpisreddevil

@dwdraju dwdraju removed the status: in progress Contributor working on issue label Sep 1, 2022
@pragyanshrestha-ibriz pragyanshrestha-ibriz added the team: ibriz Relevant to iBriz label Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team: ibriz Relevant to iBriz type: build and ci Related to internal build or continuous integration processes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants