VB -> C#: Cannot convert InvocationExpressionSyntax, System.ArgumentNullException: Value cannot be null.

[ATECoder]

Input code

        Public Shared Sub Identify(ByVal talker As ITraceMessageTalker)
            talker?.IdentifyTalker(IdentityTraceMessage())
        End Sub

Erroneous output

        public static void Identify(ITraceMessageTalker talker)
        {
            ;
#error Cannot convert ExpressionStatementSyntax - see comment for details
            /* Cannot convert InvocationExpressionSyntax, System.ArgumentNullException: Value cannot be null.
            Parameter name: node
               at Microsoft.CodeAnalysis.VisualBasic.VBSemanticModel.GetSymbolInfoForNode(SyntaxNode node, CancellationToken cancellationToken)
               at Microsoft.CodeAnalysis.VisualBasic.VBSemanticModel.GetSymbolInfoCore(SyntaxNode node, CancellationToken cancellationToken)
               at ICSharpCode.CodeConverter.CSharp.ExpressionNodeVisitor.MayThrow(ExpressionSyntax expression)
               at ICSharpCode.CodeConverter.CSharp.ExpressionNodeVisitor.FirstArgDefinitelyEvaluated(InvocationExpressionSyntax parentInvocation)
               at ICSharpCode.CodeConverter.CSharp.ExpressionNodeVisitor.DefinitelyExecutedAfterPreviousStatement(InvocationExpressionSyntax invocation)
               at ICSharpCode.CodeConverter.CSharp.ExpressionNodeVisitor.RequiresLocalFunction(InvocationExpressionSyntax invocation, IMethodSymbol invocationSymbol)
               at ICSharpCode.CodeConverter.CSharp.ExpressionNodeVisitor.<VisitInvocationExpression>d__77.MoveNext()
            --- End of stack trace from previous location where exception was thrown ---
               at ICSharpCode.CodeConverter.CSharp.CommentConvertingVisitorWrapper.<ConvertHandledAsync>d__5`1.MoveNext()

            Input: Global.isr.Algorithms.Signals.My.MyLibrary.IdentityTraceMessage()
            Context:
                        talker?.IdentifyTalker(Global.isr.Algorithms.Signals.My.MyLibrary.IdentityTraceMessage())

             */
        }

Expected output

        public static void Identify(ITraceMessageTalker talker)
        {
            talker?.IdentifyTalker( global::isr.Algorithms.Signals.My.MyLibrary.IdentityTraceMessage() );
        }

or
        public static void Identify(ITraceMessageTalker talker)
        {
            talker?.IdentifyTalker( IdentityTraceMessage() );
        }

Details

• Product in use: codeconverter.icsharpcode.net / VS extension
• Version in use: 8.1.8.0 artifact of 10/12
• Did you see it working in a previous version, which? N/A
• Any other relevant information to the issue, or your interest in contributing a fix.

This seems to be an issue with the Global. vs. global:: conversion. Was the artifact addressing the Global syntax?

[GrahamTheCoder]

Thanks, I can reproduce the issue when converting this minimal compilable unit of VB without any other context:

Imports System

Public Class AClass
        Public Shared Sub Identify(ByVal talker As ITraceMessageTalker)
            talker?.IdentifyTalker(IdentityTraceMessage())
        End Sub

    Private Shared Function IdentityTraceMessage() As Object
        Throw New NotImplementedException()
    End Function
End Class

Public Interface ITraceMessageTalker
    Function IdentifyTalker(v As Object) As Object
End Interface

The simplest fix would be just to return true if there's no symbol here:

CodeConverter/CodeConverter/CSharp/ExpressionNodeVisitor.cs

Lines 981 to 987 in 70207de

	private bool MayThrow(VBSyntax.ExpressionSyntax expression)
	{
	expression = expression.SkipIntoParens();
	if (expression is VBSyntax.InstanceExpressionSyntax) return false;
	var symbol = _semanticModel.GetSymbolInfo(expression).Symbol;
	return !symbol.IsKind(SymbolKind.Local) && !symbol.IsKind(SymbolKind.Field);
	}