VB -> C# : redim preserve bad choice for temporary var name

[v1nce]

THANK YOU for your tool.

I think there's a problem with the name of temporary array in the case of redim preserve.
It's called old%FULL_ARRAY_NAME% which breaks if the array is a property of an object instance (among multiple other possible cases)

instead of
var oldinstance.prop = instance.prop is wrong.
it should be
var oldprop = instance.prop
or something like
var __oldinstance__prop = instance.prop

Input code

ReDim Preserve instance.prop(size)

Erroneous output

var oldinstance.prop = instance.prop;
instance.prop = new string[size + 1 + 1];
if (oldinstance.prop != null)
Array.Copy(oldinstance.prop, instance.prop, Math.Min(size + 1 + 1, oldinstance.prop.Length));

Expected output

var oldinstance_prop = instance.prop;
instance.prop = new string[size + 1 + 1];
if (oldinstance_prop != null)
Array.Copy(oldinstance_prop, instance.prop, Math.Min(size + 1 + 1, oldinstance_prop.Length));

Details

VS extension

[GrahamTheCoder]

You're very welcome, thanks for reporting the issue! Yep sounds like a straightforward enough thing to fix. I'm busy for the next couple of weeks, but I'm happy to give some direction (just search redim in the codebase) and look over a PR if someone wants to implement, otherwise or I'll try to take a look at this some time in November.

…

On Wed, 23 Oct 2019 at 17:15, v1nce ***@***.***> wrote: THANK YOU for your tool. I think there's a problem with the name of temporary array in the case of redim preserve. It's called old%FULL_ARRAY_NAME% which breaks if the array is a property of an object instance (among multiple other possible cases) instead of var oldinstance.prop = instance.prop is wrong. it should be var oldprop = instance.prop or something like var __oldinstance__prop = instance.prop Input code ReDim Preserve instance.prop(size) Erroneous output var oldinstance.prop = instance.prop; instance.prop = new string[size + 1 + 1]; if (oldinstance.prop != null) Array.Copy(oldinstance.prop, instance.prop, Math.Min(size + 1 + 1, oldinstance.prop.Length)); Expected output var oldinstance_prop = instance.prop; instance.prop = new string[size + 1 + 1]; if (oldinstance_prop != null) Array.Copy(oldinstance_prop, instance.prop, Math.Min(size + 1 + 1, oldinstance_prop.Length)); Details VS extension — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#393?email_source=notifications&email_token=AATAA4QHRYFZIRWWCHNNGB3QQB2BPA5CNFSM4JEEDOF2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HT32XSQ>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AATAA4TPZ6NVSTUFPDHIA43QQB2BPANCNFSM4JEEDOFQ> .