Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ilspycmd crashing if no valid ICU package is found #2417

Closed
siegfriedpammer opened this issue May 21, 2021 · 0 comments
Closed

ilspycmd crashing if no valid ICU package is found #2417

siegfriedpammer opened this issue May 21, 2021 · 0 comments

Comments

@siegfriedpammer
Copy link
Member

$ ilspycmd
Process terminated. Couldn't find a valid ICU package installed on the system. Set the configuration flag System.Globalization.Invariant to true if you want to run with no globalization support.
   at System.Environment.FailFast(System.String)
   at System.Globalization.GlobalizationMode.GetGlobalizationInvariantMode()
   at System.Globalization.GlobalizationMode..cctor()
   at System.Globalization.CultureData.CreateCultureWithInvariantData()
   at System.Globalization.CultureData.get_Invariant()
   at System.Globalization.CultureInfo..cctor()
   at System.StringComparer..cctor()
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication..ctor(McMaster.Extensions.CommandLineUtils.CommandLineApplication, McMaster.Extensions.CommandLineUtils.HelpText.IHelpTextGenerator, McMaster.Extensions.CommandLineUtils.Abstractions.CommandLineContext, Boolean)
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication..ctor(Boolean)
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication`1[[System.__Canon, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]]..ctor(Boolean)
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.Execute[[System.__Canon, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](McMaster.Extensions.CommandLineUtils.Abstractions.CommandLineContext)
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.Execute[[System.__Canon, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](McMaster.Extensions.CommandLineUtils.IConsole, System.String[])
   at McMaster.Extensions.CommandLineUtils.CommandLineApplication.Execute[[System.__Canon, System.Private.CoreLib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]](System.String[])
   at ICSharpCode.Decompiler.Console.ILSpyCmdProgram.Main(System.String[])
Aborted (core dumped)

We should disable globalization support as described here: https://github.com/dotnet/runtime/blob/main/docs/design/features/globalization-invariant-mode.md#enabling-the-invariant-mode as it is not necessary for the decompiler to be localized.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant