Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ReflectionDisassembler to support filtering/sorting #2834

Closed
tom-englert opened this issue Nov 12, 2022 · 1 comment
Closed

Enhance ReflectionDisassembler to support filtering/sorting #2834

tom-englert opened this issue Nov 12, 2022 · 1 comment
Labels
Enhancement Areas for improvement

Comments

@tom-englert
Copy link
Contributor

tom-englert commented Nov 12, 2022

Is your feature request related to a problem? Please describe.
When using IL disassembling to verify the outcome of some IL modification, it frequently happens that tests break just because the IL layout has slightly changed, but only by the ordering of classes or members, while the IL is still the same.
Another use case is to validate IL changes by before/after comparison, which is impossible when not only a few IL statements, but the complete layout has changed.

Describe the solution you'd like
ReflectionDisassembler should support an extension point to enable sorting or filtering. By sorting classes or members, the generated IL would be identical if only the ordering of members has changed.
Filtering could be helpful to reduce the output just to the points of interest.

Additional context
See implementation and tests in #2835

@siegfriedpammer
Copy link
Member

Fixed by #2835

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Areas for improvement
Projects
None yet
Development

No branches or pull requests

2 participants