Show a dark title bar when a dark theme in ILSpy is selected

[tom-englert]

As of Windows 11 there is a possibility to change the color of the windows title bar.

"DWMWA_USE_IMMERSIVE_DARK_MODE" is supported starting with Windows 11 Build 22000.
learn.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmsetwindowattribute

This could be used to let the title bar color follow the ILSpy color theme.

Also maybe an option could be using DWMWA_CAPTION_COLOR and DWMWA_TEXT_COLOR to set the colors explicit according to ILSpy them.

[christophwille]

I have read the various comments in the PR #2947. Let's look at this from the user's point of view: if I switch a theme in ILSpy, I expect consistent behavior regardless of the OS's settings regarding light/dark. So, me being light in Win11, selecting dark in ILSpy, I would expect the title bar to follow - and not like in the PR be a no-op ("Style the window title bar" is meeting that expectation).

[tom-englert]

Also just tried a simple sample app, using DWMWA_USE_IMMERSIVE_DARK_MODE.
It will do what is expected, despite the confusing documentation: https://learn.microsoft.com/en-us/answers/questions/966330/dwmwa-use-immersive-dark-mode-confusion

However I only managed to get a pitch-black title bar, no matter what my windows settings are:

So if we anyhow ignore the windows theme settings, it would look better if we set the color individually.

[christophwille]

So if we anyhow ignore the windows theme settings, it would look better if we set the color individually.

Simply floating a few ideas: Can we query the OS light/dark colors? What I am getting at is for a theme to say "Give me the system-default dark look for the chrome" (even if light is current) vs additionally "Hey, this is the color to use" (think VS blue theme).

[tom-englert]

I tried SystemParameters.WindowGlassColor, but this gives me the same black - but maybe that's because I'm on a VM via remote desktop.
The screen shot @SlimeNull has posted looks quite different.

[SlimeNull]

Also just tried a simple sample app, using DWMWA_USE_IMMERSIVE_DARK_MODE. It will do what is expected, despite the confusing documentation: https://learn.microsoft.com/en-us/answers/questions/966330/dwmwa-use-immersive-dark-mode-confusion

However I only managed to get a pitch-black title bar, no matter what my windows settings are:

So if we anyhow ignore the windows theme settings, it would look better if we set the color individually.

If you enable this option in the settings, then the Mica effect will not be applied to your title bar.

[SlimeNull]

And I noticed that your window border is not rounded, is there no problem with the graphics card driver? Or are rounded borders disabled or some visual effects?

[SlimeNull]

So if we anyhow ignore the windows theme settings, it would look better if we set the color individually.

Simply floating a few ideas: Can we query the OS light/dark colors? What I am getting at is for a theme to say "Give me the system-default dark look for the chrome" (even if light is current) vs additionally "Hey, this is the color to use" (think VS blue theme).

I am also curious. Visual Studio customized the title bar, but its "layout options" are still available.

[SlimeNull]

In addition, I have a suggestion. Currently, ILSpy has two themes, Light and Dark. Can we introduce an "Auto" mode? When the system theme changes, it automatically switches to the target mode. In WPF, we only need to subscribe to the SystemEvents.UserPreferenceChanged event.

[tom-englert]

And I noticed that your window border is not rounded, is there no problem with the graphics card driver? Or are rounded borders disabled or some visual effects?

Yes, that's probably because its a VM, not a real machine, so my investigations here might not be fully valid.
So on a physical machine this seems to work as expected.

[tom-englert]

I am also curious. Visual Studio customized the title bar, but its "layout options" are still available.

Can be fixed via #2955

[tom-englert]

In addition, I have a suggestion. Currently, ILSpy has two themes, Light and Dark. Can we introduce an "Auto" mode? When the system theme changes, it automatically switches to the target mode. In WPF, we only need to subscribe to the SystemEvents.UserPreferenceChanged event.

Good point, but this would be a different issue.