Right panel shows old info in case all is deleted in the left-hand tree

[greenozon]

Steps to reproduce

1. Delete all assemblies
2. rihgt panel show old info

Error message shown

eg:

Copy and paste any error messages / relevant text and/or screenshot the incorrect behaviour.

Details

• ILSpy version 9.0.0.7785-preview2+c1a42ccf7205f41d9ba3988926162feb6e57ca98
  .NET version 8.0.8+08338fcaa5c9b9a8190abb99222fed12aaba956c

[siegfriedpammer]

The problem seems to be that the last tab is closed. This should not be the case. Previously the last tab was uncloseable.

[christophwille]

By previously you mean pre- #3274?

[greenozon]

added video show

vid-.2024-09-29.10-57-52-579.mp4

[siegfriedpammer]

By previously you mean pre- #3274?

Yes, our latest official release shows the following, if the assembly list is empty:

There is a tab "New tab" with no content. From @greenozon's first screenshot, we can see that in the current master, there can be zero open tabs, which is not desired, because ILSpy is essentially an SDI application, with the possibility to view multiple documents. if necessary.

[christophwille]

@tom-englert

[siegfriedpammer]

@tom-englert I can still reproduce this using the latest master (ILSpy version 9.0.0.7802-preview2+7f46aab34493d01edf9801df6b86fc14d5c8ae62):

1. create/open non-empty assembly list
2. ctrl+a all tree nodes
3. hit delete
4. observe that the decompilation view is reloading/still showing old info

I also noticed that switching the current assembly list while a decompilation is in progress, it's not cancelled. When switching tree nodes the old decompilation is cancelled. I would expect the same to happen, when switching the assembly list mid-progress.

I will try to look into this, but ever since the refactoring I am no longer sure how the code is supposed to work/be organized, so actually fixing stuff is a lot harder. The code is organized better, but I still have to get used to it.

[tom-englert]

@siegfriedpammer I'll have a look, too