Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to compile on Crystal 0.31.0 #21

Closed
Hentioe opened this issue Sep 25, 2019 · 2 comments
Closed

Unable to compile on Crystal 0.31.0 #21

Hentioe opened this issue Sep 25, 2019 · 2 comments

Comments

@Hentioe
Copy link

Hentioe commented Sep 25, 2019 •
edited
Loading

Changing / to // can solve some errors, and adding a return type to the overridden method can eliminate some warnings.

However, Channel was refactored and the Channel::Buffered(T)#full? method was removed. I don't know how to modify it, so I didn't open a PR.
@icyleaf icyleaf mentioned this issue Sep 25, 2019
Merged
@icyleaf
Copy link
Owner

icyleaf commented Sep 25, 2019

@Hentioe i fix it but i did not found what you figure issue, would you explain it please?

@Hentioe
Copy link
Author

Hentioe commented Sep 25, 2019

Has been fixed.

@Hentioe Hentioe closed this as completed Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@icyleaf @Hentioe