Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<p> nesting is inconsistent #130

Closed
mathisonian opened this issue Sep 1, 2017 · 3 comments
Closed

<p> nesting is inconsistent #130

mathisonian opened this issue Sep 1, 2017 · 3 comments
Labels

Comments

@mathisonian
Copy link
Member

Issue by rreusser
Saturday May 20, 2017 at 19:45 GMT
Originally opened as idyll-lang/idyll-compiler#20


p tag nesting is a little inconsistent, which makes it challenging to manage formatting. For example,

[li]test[/li] --> <li>test</li>

whereas:

[li]**test**[/li] --> <li><p><strong>test</strong></p></li>

Perhaps it would be better if everything were nested in a p tag when not already. I suspect this is how markdown does it, though it would be worth checking.

@mathisonian
Copy link
Member Author

Comment by rreusser
Thursday May 25, 2017 at 22:19 GMT


Actually, checking over what github's markdown renderer does by inspecting this box, it seems the default is not to wrap in a p tag in most cases. A few sanity checks confirm that things basically make pretty good sense:

  • Test<p>Test</p>
  • <p>Test</p><p>Test</p>
  • **Test**<p><strong>Test</strong></p>
  • # **Test**<h1><strong>Test</strong></h1>
  • Adding a line break between any one of the items of a list triggers wrapping each <li>'s content in a p tag. Otherwise they're bare.

@mathisonian
Copy link
Member Author

Comment by mathisonian
Friday May 26, 2017 at 07:41 GMT


Is this issue just for nesting <p>s inside of a list, or is it more general?

The updates I pushed to support nesting markdown syntax inside of the list syntax should help clean this up a little bit.

@mathisonian
Copy link
Member Author

Comment by rreusser
Saturday May 27, 2017 at 17:25 GMT


Found one more case that's a bit problematic:

[span][span]test[/span][/span] is rendered as <p><span><p><span>test</span></p></span></p> so that you can't currently nested components inline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant