Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use of x/params #2745

Closed
Tracked by #3050
aljo242 opened this issue Aug 12, 2022 · 1 comment
Closed
Tracked by #3050

Deprecate use of x/params #2745

aljo242 opened this issue Aug 12, 2022 · 1 comment
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding.
Milestone

Comments

@aljo242
Copy link
Contributor

aljo242 commented Aug 12, 2022

The Cosmos SDK is moving to deprecate the usage of the x/params module in future releases (starting in v0.47.x I believe). This is because x/params contains some of the remaining usages of AMINO in the codebase.

Modules will now self manage parameters. Overall, this makes sense as it removes AMINO and decouples modules a bit more. More details can be found with the corresponding ADR.

Updated templates will include:

  • removing x/params from the app template
  • scaffolding new modules with an UpdateParams Tx
  • add an authority field to the module keeper. This is an address that is enabled by governance to submit the UpdateParams Tx (authtypes.NewModuleAddress(govtypes.ModuleName).String())

Here is an example of migrating away from x/params in the x/distr module:

@aljo242 aljo242 added type:request Feature request. sdk/stargate and removed sdk/stargate type:request Feature request. labels Aug 12, 2022
@fadeev fadeev added component:scaffold Feature, enhancement, or refactor related to scaffolding. and removed noteworthy labels Sep 17, 2022
@aljo242 aljo242 mentioned this issue Nov 3, 2022
4 tasks
@aljo242 aljo242 added this to the v0.27.0 milestone Dec 16, 2022
@Pantani Pantani closed this as completed Oct 17, 2023
@julienrbrt
Copy link
Member

I think we could stop scaffolding it by default as well from SDK v0.51, as I believe IBC and CosmWasm are having their migration for v0.50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:scaffold Feature, enhancement, or refactor related to scaffolding.
Projects
None yet
Development

No branches or pull requests

4 participants