Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/plugin package shouldn't use pkg/cliui directly #3289

Closed
Tracked by #3070
tbruyelle opened this issue Dec 14, 2022 · 1 comment · Fixed by #3271
Closed
Tracked by #3070

services/plugin package shouldn't use pkg/cliui directly #3289

tbruyelle opened this issue Dec 14, 2022 · 1 comment · Fixed by #3271
Assignees
@aljo242
Labels
type:error Something isn't working
Milestone
v0.26.0

Comments

@tbruyelle
Copy link
Contributor

It should interact only with the EventBus, like other packages in services.
@tbruyelle tbruyelle added the type:error Something isn't working label Dec 14, 2022
@tbruyelle tbruyelle mentioned this issue Dec 14, 2022
Closed
15 tasks
@tbruyelle tbruyelle added this to the v0.26.0 milestone Dec 14, 2022
@aljo242 aljo242 self-assigned this Dec 14, 2022
@aljo242
Copy link
Contributor

aljo242 commented Dec 14, 2022

direct usage of cliui is causing race condition - will fix test failing as well

@aljo242 aljo242 mentioned this issue Dec 14, 2022
Merged
@vutting4221 vutting4221 mentioned this issue Jan 2, 2024
Open
@vutting4221 vutting4221 mentioned this issue Mar 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aljo242 aljo242

Labels
type:error Something isn't working
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging a pull request may close this issue.

fix: test and test script ignite/cli
2 participants
@tbruyelle @aljo242