Tutorial about developing with cmake and colcon #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
developing_with_ign-cmake
branch
from
51fa1b6 to
e812519
Compare
Signed-off-by: Michael Carroll <[email protected]>
ahcorde
requested changes
Jan 12, 2021
ahcorde
reviewed
Jan 12, 2021
ahcorde
reviewed
Jan 12, 2021
Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Done, thanks for catching that. |
chapulina
reviewed
Jan 12, 2021
| "-DCMAKE_CXX_COMPILER_LAUNCHER=ccache" | ||
| ``` | ||
|
|
||
| ### Enabling/Disabling Documentation |
There was a problem hiding this comment.
You could also have a section for BUILD_TESTING, and BUILDSYSTEM_TESTING
chapulina
approved these changes
Jan 12, 2021
adlarkin
reviewed
Jan 12, 2021
| mkdir -p ~/ign_edifice/src | ||
| cd ~/ign_edifice/ | ||
| wget https://raw.githubusercontent.com/ignition-tooling/gazebodistro/master/collection-edifice.yaml | ||
| vcs import src < collection-edifice.yaml |
There was a problem hiding this comment.
We should add a note about installing vcs in case users don't have this installed already.
There was a problem hiding this comment.
I have a note in the level 2 section that redirects to the ignition source installation documentation that should cover this, is that sufficient?
There was a problem hiding this comment.
I had the same thought after I commented. Perhaps we can just mention users should go back to section 2 if they don't have vcs installed yet?
Co-authored-by: Louise Poubel <[email protected]> Co-authored-by: Ashton Larkin <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to document a bit around useful CMake flags as well as interaction with colcon and how to speed up builds.
I'm open to relocating this if there is somewhere more useful.
Signed-off-by: Michael Carroll [email protected]