Fix use of FindIgnOGRE2 on Windows if OGRE2 is not found #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a library is not found, a Find<package>.cmake should fail by setting <package>_FOUND to FALSE, not make the CMake configuration exit with a fatal error using message(FATAL_ERROR ...). Signed-off-by: Silvio Traversaro <[email protected]>
traversaro
force-pushed
the
fix-findignogre2-win
branch
from
beed7e9 to
ca60ce0
Compare
mxgrey
approved these changes
May 11, 2020
chapulina
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a library is not found, a
Find<package>.cmakeshould fail by setting<package>_FOUNDtoFALSE, not make the CMake configuration exit with a fatal error usingmessage(FATAL_ERROR ...).This change fixes the compilation of ignition-rendering on Windows when
OGRE2/ogre-nextis not installed.