Edifice deprecations #159
Merged
Edifice deprecations #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 77.99% 77.85% -0.14%
==========================================
Files 19 19
Lines 2604 2606 +2
==========================================
- Hits 2031 2029 -2
- Misses 573 577 +4
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
nkoenig
approved these changes
Jan 14, 2021
Signed-off-by: Louise Poubel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated
FuelClient::DeleteModel.LocalCacheis deprecated in v5, but it can't be removed in v6 because it's used in a public constructor ofFuelClient. So I deprecated that constructor and we can only moveLocalCachetosrcin v7.