Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added public/private editing #67

Merged
merged 11 commits into from
Jun 9, 2020
Merged

Added public/private editing #67

merged 11 commits into from
Jun 9, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 5, 2020

Add support for editing models via a PATCH call. I'm limiting the scope of this PR to just the public/private field in models.

@chapulina chapulina changed the base branch from reorder to ign-fuel-tools4 May 6, 2020 18:25
@chapulina chapulina added enhancement New feature or request 🏰 citadel Ignition Citadel labels May 6, 2020
@chapulina
Copy link
Contributor

There are conflicts to be resolved

@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #67 into ign-fuel-tools4 will decrease coverage by 1.89%.
The diff coverage is 9.30%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4      #67      +/-   ##
===================================================
- Coverage            78.50%   76.60%   -1.90%     
===================================================
  Files                   16       16              
  Lines                 2214     2278      +64     
===================================================
+ Hits                  1738     1745       +7     
- Misses                 476      533      +57     
Impacted Files Coverage Δ
include/ignition/fuel_tools/RestClient.hh 100.00% <ø> (ø)
src/RestClient.cc 56.48% <0.00%> (-3.68%) ⬇️
src/Result.cc 90.90% <0.00%> (-9.10%) ⬇️
src/ign.cc 55.15% <0.00%> (-5.72%) ⬇️
src/FuelClient.cc 70.34% <17.64%> (-1.82%) ⬇️
src/ModelIdentifier.cc 92.26% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ded4bf...b4a0925. Read the comment docs.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only suggestion I have is documenting the new command on the README and tutorials.

@nkoenig nkoenig requested a review from maryaB-osr as a code owner June 9, 2020 19:43
@nkoenig
Copy link
Contributor Author

nkoenig commented Jun 9, 2020

Updated tutorial: b4a0925

@nkoenig nkoenig merged commit 507d0fa into ign-fuel-tools4 Jun 9, 2020
@nkoenig nkoenig deleted the edit branch June 9, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants