Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License handling #69

Merged
merged 7 commits into from
Jun 11, 2020
Merged

License handling #69

merged 7 commits into from
Jun 11, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 11, 2020

This pull request modifies model upload to:

Request the set of available licenses from the Fuel sever.
Use the available licenses along with the legal section of a metadata.pbtxt file to set the correct license.

@nkoenig nkoenig changed the base branch from master to ign-fuel-tools4 May 11, 2020 12:30
@codecov
Copy link

codecov bot commented May 11, 2020

Codecov Report

Merging #69 into ign-fuel-tools4 will decrease coverage by 1.09%.
The diff coverage is 33.87%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4      #69      +/-   ##
===================================================
- Coverage            76.60%   75.50%   -1.10%     
===================================================
  Files                   16       16              
  Lines                 2278     2339      +61     
===================================================
+ Hits                  1745     1766      +21     
- Misses                 533      573      +40     
Impacted Files Coverage Δ
src/FuelClient.cc 66.66% <0.00%> (-3.68%) ⬇️
src/ign.cc 54.98% <0.00%> (-0.17%) ⬇️
src/JSONParser.cc 80.34% <67.74%> (-2.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 507d0fa...5d056c2. Read the comment docs.

Nate Koenig added 3 commits May 11, 2020 05:34
@chapulina chapulina self-requested a review May 11, 2020 18:46
@chapulina chapulina added the 🏰 citadel Ignition Citadel label May 12, 2020
Changelog.md Outdated Show resolved Hide resolved
include/ignition/fuel_tools/JSONParser.hh Outdated Show resolved Hide resolved
src/FuelClient.cc Outdated Show resolved Hide resolved
@chapulina chapulina requested a review from j-rivero June 8, 2020 18:38
Nate Koenig added 2 commits June 9, 2020 13:05
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Copy link
Contributor Author

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated legal handling per suggestion in: aba1a14

Changelog.md Outdated Show resolved Hide resolved
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit fb39d3f into ign-fuel-tools4 Jun 11, 2020
@chapulina chapulina deleted the license_handling2 branch June 11, 2020 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants