Fix test failures due to recent changes in SDFormat #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix invalid pose (7 values instead of 6) * Add a special case for comparing poses since 0 can sometimes be generated as -0. * Make isSubset return AssertionResult with helpful failure messages Signed-off-by: Addisu Z. Taddese <[email protected]>
Merged
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
- Coverage 64.66% 63.41% -1.25%
==========================================
Files 242 238 -4
Lines 19014 19398 +384
==========================================
+ Hits 12296 12302 +6
- Misses 6718 7096 +378
Continue to review full report at Codecov.
|
chapulina
added
beta
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
* Fix invalid pose (7 values instead of 6) * Add a special case for comparing poses since 0 can sometimes be generated as -0. * Make isSubset return AssertionResult with helpful failure messages Signed-off-by: Addisu Z. Taddese <[email protected]> Signed-off-by: William Lew <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
generated as -0.
isSubsetreturnAssertionResultwith helpful failure messagesChecklist
[ ] Updated documentation (as needed)[ ] Updated migration guide (as needed)codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge