Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows build #1033

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Fix Windows build #1033

merged 1 commit into from
Sep 16, 2021

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel [email protected]

🦟 Bug fix

Fixes #1030

Summary

Renamed reserved word.

My bad for merging #1003 without passing Windows CI, but in my defense, #990 is making PR review very difficult.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina added bug Something isn't working Windows Windows support beta Targeting beta release of upcoming collection labels Sep 16, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #1033 (e6a72d3) into main (1e1d0ba) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
+ Coverage   63.27%   63.30%   +0.03%     
==========================================
  Files         239      239              
  Lines       19464    19464              
==========================================
+ Hits        12316    12322       +6     
+ Misses       7148     7142       -6     
Impacted Files Coverage Δ
...int_position_controller/JointPositionController.cc 75.19% <ø> (ø)
src/SimulationRunner.cc 93.92% <0.00%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e1d0ba...e6a72d3. Read the comment docs.

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like its building now, although there seem to be other issues with the windows build. In particular there is some wierd "invalid vector subscript" error in the test case. My bad also for not checking the Windows build.

@chapulina
Copy link
Contributor Author

Looks like its building now, although there seem to be other issues with the windows build

Yup, that's the current state of the Windows build 🙃 Thanks for the review!

@chapulina chapulina merged commit 7ffcf4c into main Sep 16, 2021
@chapulina chapulina deleted the chapulina/6/win branch September 16, 2021 02:18
WilliamLewww pushed a commit to WilliamLewww/ign-gazebo that referenced this pull request Dec 7, 2021
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: William Lew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress Windows Windows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants