Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI crash when accessing bad rendering UserData #1052

Merged
merged 2 commits into from
Sep 25, 2021

Conversation

chapulina
Copy link
Contributor

🦟 Bug fix

Summary

Fix a bug that came up during the tutorial party. Without this fix, the AlignTool plugin crashes on use.

I went ahead and guarded all instances of UserData that weren't already protected by try / catch blocks.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering beta Targeting beta release of upcoming collection labels Sep 24, 2021
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Sep 24, 2021
@adlarkin
Copy link
Contributor

Looks like codecheck is failing:

  Scanning dependencies of target cpplint
  /github/workspace/src/gui/plugins/align_tool/AlignTool.cc:368:  Line ends in whitespace.  Consider deleting these extra spaces.  [whitespace/end_of_line] [4]
  Total errors found: 1
  CMakeFiles/cpplint.dir/build.make:57: recipe for target 'CMakeFiles/cpplint' failed
  make[3]: *** [CMakeFiles/cpplint] Error 1
  CMakeFiles/Makefile2:1161: recipe for target 'CMakeFiles/cpplint.dir/all' failed
  make[2]: *** [CMakeFiles/cpplint.dir/all] Error 2
  CMakeFiles/Makefile2:880: recipe for target 'CMakeFiles/codecheck.dir/rule' failed
  make[1]: *** [CMakeFiles/codecheck.dir/rule] Error 2
  Makefile:522: recipe for target 'codecheck' failed
  make: *** [codecheck] Error 2

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 7288984 into main Sep 25, 2021
@chapulina chapulina deleted the chapulina/6/userdata_bug branch September 25, 2021 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection bug Something isn't working 🏯 fortress Ignition Fortress GUI Gazebo's graphical interface (not pure Ignition GUI) rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants