Publish 10 world stats msgs/sec instead of 5

[adlarkin]

Signed-off-by: Ashton Larkin [email protected]

Addresses #1109 (comment)

Summary

The changes made in #1109 and gazebosim/gz-gui#306 result in the GUI listening to the world stats topic to receive play/pause confirmations from the server. The publisher of this topic is currently publishing 5 msgs/second, but I think it would be good to publish at a higher rate to decrease response times between a GUI play/pause button press and server confirmation.

Test it

Use these changes with #1109 and try pressing play/pause/step in the GUI. The GUI response times should be a little faster now.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

[chapulina]

I'm afraid we may be tweaking this hardcoded value often. We could consider exposing this as an option on ServerConfig, and optionally as a command line option, but that may be overkill. Defaulting to something that makes the GUI usable makes sense to me.

[adlarkin]

I'm afraid we may be tweaking this hardcoded value often. We could consider exposing this as an option on ServerConfig, and optionally as a command line option, but that may be overkill. Defaulting to something that makes the GUI usable makes sense to me.

It would be nice to remove hardcoded values whenever possible. We can make this adjustable on ServerConfig, or at least add a comment in the code that explains why 10 is used. Would it be worth making either of these additions/changes before merging this PR?

[codecov]

Codecov Report

Merging #1163 (145b177) into ign-gazebo6 (4e879a8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           ign-gazebo6    #1163      +/-   ##
===============================================
+ Coverage        63.69%   63.72%   +0.02%     
===============================================
  Files              256      256              
  Lines            20116    20116              
===============================================
+ Hits             12813    12819       +6     
+ Misses            7303     7297       -6     

Impacted Files	Coverage Δ
src/SimulationRunner.cc	93.92% <100.00%> (+1.01%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e879a8...145b177. Read the comment docs.

[chapulina]

Would it be worth making either of these additions/changes before merging this PR?

I'd say at least the comment would be a good idea. I'm fine exposing the parameter in a later PR. We may want to think a bit more about how to expose these "small" options, so that we don't bloat ServerConfig and the command line options

[adlarkin]

I'd say at least the comment would be a good idea.

I left a comment in 145b177. We should wait to merge this until gazebosim/gz-gui#306 and #1163 are merged in order for the comment to make sense with the git history.

I'm fine exposing the parameter in a later PR. We may want to think a bit more about how to expose these "small" options, so that we don't bloat ServerConfig and the command line options

I've opened an issue for this (#1164). We can have the discussion there.