-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend odom publisher to allow 3D #1180
Extend odom publisher to allow 3D #1180
Conversation
Signed-off-by: Blake McHale <[email protected]>
@chapulina @vatanaksoytezer This is exactly the same PR as before, but based off a different branch with a cleaner commit history. I made all the requested modifications from the other PR. Thanks for helping me out and let me know if there's anything else I should change! |
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating, @blakermchale ! LGTM. I pushed 879eda3 adding the odometry plugin to an example world so people have a reference for how to use it.
@chapulina thanks a ton for to review 🥳 . When should we expect this to get this synced on Fortress and then released? We want to use Fortress binaries in projects but this was the main feature that was forcing us to use Edifice from source. |
I'm going to work on it soon, if all goes well I think we can have this in Fortress by the end of the week. |
That's fast 🏁, thanks @chapulina ! |
Btw, it took a bit longer, but this is released into 5.3 (Edifice) and 6.2 (Fortress). |
Awesome thanks for letting me know and releasing this, I'll update my Ignition binaries! |
Signed-off-by: Blake McHale <[email protected]> Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: Louise Poubel <[email protected]> Signed-off-by: William Lew <[email protected]>
Signed-off-by: Blake McHale [email protected]
🎉 New feature
Closes #934 and replaces #941.
Summary
This adds in a new tag
<dimensions>
to the odometry publisher plugin that accepts either 2 or 3 (defaults to 2). When the value is 3 it assumes a 3D assumption instead of planar. This is useful for people who want to know the z location and angular rates. In my use case, I was using the multicopter plugin with the X3 model.Test it
This feature can be tested by running the
INTEGRATION_odometry_publisher
test or adding the tag to the plugin in an SDF file. I tested this manually and echoed the odometry topic while commanding the multicopter with velocities.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge