Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for moving the GUI camera to a pose #352

Merged
merged 6 commits into from
Sep 22, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 15, 2020

Also added a topic to publish the camera pose.

There are situation where I would like to move the user camera to a pose that is not associated with a model.

Signed-off-by: Nate Koenig [email protected]

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… publich the camera pose

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig nkoenig requested a review from iche033 September 15, 2020 19:53
@nkoenig nkoenig requested a review from chapulina as a code owner September 15, 2020 19:53
@chapulina chapulina added enhancement New feature or request rendering Involves Ignition Rendering 🏰 citadel Ignition Citadel labels Sep 15, 2020
@chapulina
Copy link
Contributor

Can you fix the conflicts, @nkoenig ?

I'll also mention issue #101 for cross-referencing, since this solves half of that issue.

Signed-off-by: Nate Koenig <[email protected]>
@nkoenig
Copy link
Contributor Author

nkoenig commented Sep 15, 2020

Can you fix the conflicts, @nkoenig ?

I'll also mention issue #101 for cross-referencing, since this solves half of that issue.

Resolved, and thanks for the link.

Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, just some minor comments

src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Just minor comments.

src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
src/gui/plugins/scene3d/Scene3D.cc Outdated Show resolved Hide resolved
Signed-off-by: Nate Koenig <[email protected]>
@chapulina chapulina merged commit 19227d6 into ign-gazebo3 Sep 22, 2020
@chapulina chapulina deleted the gui_cam_moveto_pose branch September 22, 2020 03:57
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Guillaume Doisy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel enhancement New feature or request rendering Involves Ignition Rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants