Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mouse highlighting for resource spawner #402

Merged
merged 5 commits into from
Oct 27, 2020

Conversation

JShep1
Copy link

@JShep1 JShep1 commented Oct 9, 2020

I just noticed I couldn't highlight/select the text in the resource spawner search bar which is a little inconvenient so I enabled it by setting selectByMouse to true.

Signed-off-by: John Shepherd [email protected]

Signed-off-by: John Shepherd <[email protected]>
@JShep1 JShep1 requested a review from chapulina as a code owner October 9, 2020 23:36
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Oct 9, 2020
@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #402 into ign-gazebo3 will increase coverage by 11.59%.
The diff coverage is 80.21%.

Impacted file tree graph

@@               Coverage Diff                @@
##           ign-gazebo3     #402       +/-   ##
================================================
+ Coverage        65.71%   77.30%   +11.59%     
================================================
  Files              127      205       +78     
  Lines             6238    11018     +4780     
================================================
+ Hits              4099     8518     +4419     
- Misses            2139     2500      +361     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Link.hh 100.00% <ø> (ø)
include/ignition/gazebo/Model.hh 100.00% <ø> (ø)
include/ignition/gazebo/SdfEntityCreator.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiEvents.hh 0.00% <0.00%> (ø)
src/SimulationRunner.hh 100.00% <ø> (ø)
.../plugins/component_inspector/ComponentInspector.hh 28.57% <ø> (ø)
src/gui/plugins/entity_tree/EntityTree.cc 9.89% <0.00%> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1680ebb...fd64d93. Read the comment docs.

@chapulina chapulina merged commit 97b69c9 into ign-gazebo3 Oct 27, 2020
@chapulina chapulina deleted the jshep1/add_mouse_highlight branch October 27, 2020 00:33
doisyg pushed a commit to wyca-robotics/ign-gazebo that referenced this pull request Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants